Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array literal handling #13345

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

  • Store array (primitive array if possible) instead of List in LiteralContext because it is the internal representation of array
  • Fix the missing int bits conversion for FLOAT_ARRAY
  • Add array support in RexExpression.Literal for future proof

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 62.92135% with 66 lines in your changes missing coverage. Please review.

Project coverage is 61.99%. Comparing base (59551e4) to head (acdfcdc).
Report is 584 commits behind head on master.

Files Patch % Lines
...e/pinot/common/request/context/LiteralContext.java 56.52% 22 Missing and 8 partials ⚠️
...egation/function/HistogramAggregationFunction.java 40.00% 7 Missing and 8 partials ⚠️
...nsform/function/ArrayLiteralTransformFunction.java 0.00% 8 Missing ⚠️
...pache/pinot/common/utils/request/RequestUtils.java 60.00% 6 Missing ⚠️
...core/query/executor/ServerQueryExecutorV1Impl.java 0.00% 3 Missing ⚠️
...pinot/query/parser/CalciteRexExpressionParser.java 75.00% 1 Missing and 1 partial ⚠️
...r/transform/function/TransformFunctionFactory.java 50.00% 0 Missing and 1 partial ⚠️
...che/pinot/query/planner/logical/RexExpression.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13345      +/-   ##
============================================
+ Coverage     61.75%   61.99%   +0.24%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2545     +109     
  Lines        133233   139817    +6584     
  Branches      20636    21695    +1059     
============================================
+ Hits          82274    86684    +4410     
- Misses        44911    46567    +1656     
- Partials       6048     6566     +518     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 27.72% <0.00%> (-33.99%) ⬇️
java-21 61.99% <62.92%> (+0.37%) ⬆️
skip-bytebuffers-false 61.95% <61.79%> (+0.21%) ⬆️
skip-bytebuffers-true 61.97% <62.92%> (+34.24%) ⬆️
temurin 61.99% <62.92%> (+0.24%) ⬆️
unittests 61.99% <62.92%> (+0.24%) ⬆️
unittests1 46.53% <62.92%> (-0.36%) ⬇️
unittests2 27.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the fix_array_literal_handling branch 2 times, most recently from bc9cd30 to 12a800e Compare June 8, 2024 22:46
@Jackie-Jiang Jackie-Jiang force-pushed the fix_array_literal_handling branch from 12a800e to acdfcdc Compare June 9, 2024 01:14
@Jackie-Jiang Jackie-Jiang merged commit 8e5e8d9 into apache:master Jun 9, 2024
20 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_array_literal_handling branch June 9, 2024 04:23
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants