add url assertion to SegmentCompletionProtocolTest #13373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullis
force-pushed
the
SegmentCompletionProtocolTest-assertion-url
branch
from
25b93cd to
18eda6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13373 +/- ##
============================================
+ Coverage 61.75% 62.00% +0.25%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140257 +7024
Branches 20636 21801 +1165
============================================
+ Hits 82274 86965 +4691
- Misses 44911 46699 +1788
- Partials 6048 6593 +545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ready for review. |
|
PTAL @Jackie-Jiang |
sullis
force-pushed
the
SegmentCompletionProtocolTest-assertion-url
branch
from
beede9c to
d19ee80
Compare
sullis
force-pushed
the
SegmentCompletionProtocolTest-assertion-url
branch
from
d19ee80 to
d4a368a
Compare
Jackie-Jiang
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.