Allow stop to interrupt the consumer thread and safely release the resource #13418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sajjad-moradi @mcvsubbu I don't find a good way to add a unit test for it. Can you please help verify the fix? |
gortiz
reviewed
Jun 18, 2024
...re/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
Show resolved
Hide resolved
|
Sajjad and I will review this and get back to you. Please hold merging |
sajjad-moradi
approved these changes
Jun 19, 2024
|
Subbu also wants to take a 2nd look. Could you please hold off merging till we have his review as well? |
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #13398 and #10861, and maybe #13263
stop()interrupt the consumer thread if it is not invoked by the same thread, and wait for it to joinstop()is already invoked (_shouldStopis set)stop()is invoked, we can guarantee the consumer thread is stopped, and we may safely release the resources held by the consumer