Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kafka partition number to metadata. #13447

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

davizucon
Copy link
Contributor

@davizucon davizucon commented Jun 20, 2024

Added Kafka partition number to be available to schema metadata __metadata$partition when "stream.kafka.metadata.populate": "true" in table config

Schema snippet:

{
"name": "__metadata$offset",
    ...
},
{
"name": "__metadata$partition",
    ...
},

Related documentation: PR 353 in pinot-docs repo.

@Jackie-Jiang
Copy link
Contributor

The change looks good! Can you elaborate a little bit more on how do you plan to use the partition info? It should be available from the consumer already

@davizucon
Copy link
Contributor Author

Thanks for the review! If there is any way to get partition info instead this PR, pls point me out.

There is a system where the distribution of messages in the partitions is based on a particular key and algorithm. With partition info we can see how producers are performing. Among other information. Thus we can see if there is any queueing in partitions, which may eventually cause some contentention for consumers.

@Jackie-Jiang
Copy link
Contributor

The consumer is created based on the stream partition, but I guess exposing this info through metadata from the upstream is anyway useful for debugging purpose

@Jackie-Jiang Jackie-Jiang merged commit cecfe51 into apache:master Jun 24, 2024
20 checks passed
suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants