Introduce "real" integration tests #778
Conversation
adutra
requested review from
ashvina,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
flyrain and
ebyhr
as code owners
| @QuarkusTest | ||
| public class QuarkusSparkIntegrationTest extends PolarisSparkIntegrationTest {} | ||
| @QuarkusIntegrationTest | ||
| public class QuarkusSparkIT extends PolarisSparkIntegrationTest {} |
There was a problem hiding this comment.
I removed this test from the test directory but left the others, because this one is a bit more heavy-weight.
| @@ -72,6 +72,8 @@ quarkus.otel.sdk.disabled=false | |||
| # quarkus.otel.traces.sampler=parentbased_always_on | |||
| # quarkus.otel.traces.sampler.arg=1.0d | |||
|
|
|||
| quarkus.test.integration-test-profile=test | |||
There was a problem hiding this comment.
This is required for now, but a bit unfortunate. I will look into making the test profile converge towards the prod profile later on.
| import org.apache.polaris.service.it.test.PolarisRestCatalogIntegrationTest; | ||
|
|
||
| @QuarkusIntegrationTest | ||
| public class QuarkusRestCatalogIT extends PolarisRestCatalogIntegrationTest {} |
There was a problem hiding this comment.
Suggestion: if tests can work with the same server, it might be an option to rung them via a JUnit5 "suite". This way we can have only one class that references the package of tests from polaris-test and also leverage JUnit5 parallelism as opposed to Gradle test parallelism.
I did not do that under DW only because it was hard to share DW servers between test threads. Now, it looks like all tests are segregated by in entity names and servers are in a separate JVM... so it might work :)
There was a problem hiding this comment.
Hmm I haven't used JUnit5 suites. Mind if we do your suggestion in another PR?
There was a problem hiding this comment.
absolutely (it's one additional dependency for the "suite" engine, by the way)
For now, some tests will fail due to #769.