Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Flush no batch message when call producer.flush #98

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

shibd
Copy link
Member

@shibd shibd commented Nov 1, 2022

Motivation

#51

Modifications

  • when calling producer.flush, wait for no batch message send suceese.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd force-pushed the fix_producer_flush branch from be0625a to b93a327 Compare November 1, 2022 10:26
@BewareMyPower BewareMyPower added bug Something isn't working release/3.0 labels Nov 1, 2022
Copy link
Member

@Demogorgon314 Demogorgon314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lib/OpSendMsg.h Show resolved Hide resolved
@BewareMyPower BewareMyPower merged commit 69e5680 into apache:main Nov 3, 2022
@RobertIndie RobertIndie added this to the 3.1.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants