Apply suggestions from code review

Co-authored-by: Zike Yang <[email protected]>
apache · Dec 30, 2024 · e585818 · e585818
1 parent 0e90dee
commit e585818
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pulsar/consumer_test.go b/pulsar/consumer_test.go
@@ -5057,11 +5057,11 @@ func TestSelectConnectionForSameConsumer(t *testing.T) {
 	assert.NoError(t, err)
 	defer _consumer.Close()
 
-	partitionConsumerImp := _consumer.(*consumer).consumers[0]
+	partitionConsumerImpl := _consumer.(*consumer).consumers[0]
 	conn := partitionConsumerImp._getConn()
 
 	for i := 0; i < 5; i++ {
-		partitionConsumerImp.grabConn("")
+		assert.NoError(t, partitionConsumerImp.grabConn(""))
 		assert.Equal(t, conn.ID(), partitionConsumerImp._getConn().ID(),
 			"The consumer uses a different connection when reconnecting")
 	}

diff --git a/pulsar/internal/connection_pool.go b/pulsar/internal/connection_pool.go
@@ -90,7 +90,8 @@ func NewConnectionPool(
 func (p *connectionPool) GetConnection(logicalAddr *url.URL, physicalAddr *url.URL,
 	keySuffix int32) (Connection, error) {
 	p.log.WithField("logicalAddr", logicalAddr).
-		WithField("physicalAddr", physicalAddr).Debug("Getting pooled connection")
+		WithField("physicalAddr", physicalAddr).
+		WithField("keySuffix", keySuffix).Debug("Getting pooled connection")
 	key := fmt.Sprint(logicalAddr.Host, "-", physicalAddr.Host, "-", keySuffix)
 
 	p.Lock()