[Improve][Producer] Refactor internalSend() and resouce managment #1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
Master Issue:
Motivation
sendRequest
to thedataChan
, but currently, we do schema-encoding/compressing ininternalSend()
, this may lead to inaccurate memory limit cotrolling, and as described in [Improve][Producer]Simplify the MaxPendingMessages controlling #1043, make the code complicated and difficult to maintain, we need to simplify the send logic;Modifications
internalSend()
tointernalSendAsync()
;internalSend()
tointernalSendAsync()
;sendRequest
store the semaphore and memory it holds;internalSendAsync()
clearer;sendRequest.done()
to release the resources it holds;sendRequest
is done, callsendRequest.done()
;sendRequest.done()
run callback, update metrics, end transaction, run interceptors callback...Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation