-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue 513] fix batch size limit validation #528
Conversation
@zzzming Thanks work for this, the change LGTM +1, please fix CI error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zzzming Any update for this change? |
Please merge master code and fix CI error, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzzming please merge master code and fix conflict
c1228fc
to
6e18a3f
Compare
Fixes #513
fix batch size limit validation
Motivation
The current batch size validation is incorrect.
Modifications
The batch max size should be used to compare against the current size. The message should be flushed when the max size is reached.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation