Handle nil value message correctly in table-view #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
Demogorgon314/table-view-nil-value
branch
from
83d8e66 to
77e23e9
Compare
Demogorgon314
force-pushed
the
Demogorgon314/table-view-nil-value
branch
from
f1fc1ec to
d1b4837
Compare
nodece
approved these changes
Jan 3, 2023
BewareMyPower
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when we publish a nil value message(tombstones) to a compacted topic used to
TableView, theTableViewwill store a nil value in the map, but we should remove this key since this is a tombstone.Modifications