-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP-165] Auto release idle connections #963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the newly added unit test has a timeout. time="2023-03-01T10:41:21Z" level=info msg="Connecting to broker" remote_addr="pulsar://localhost:6650"
time="2023-03-01T10:41:21Z" level=info msg="TCP connection established" local_addr="127.0.0.1:42264" remote_addr="pulsar://localhost:6650"
time="2023-03-01T10:41:21Z" level=info msg="Connection is ready" local_addr="127.0.0.1:42264" remote_addr="pulsar://localhost:6650"
client_impl_test.go:1224:
Error Trace: /pulsar/pulsar-client-go/pulsar/client_impl_test.go:1224
Error: Expected nil, but got: &errors.errorString{s:"request timed out"}
Test: TestAutoCloseIdleConnection
coverage: 29.7% of statements
panic: test timed out after 20m0s |
shibd
reviewed
Mar 1, 2023
@shibd Thanks. It's a deadlock issue. I have fixed it. |
shibd
reviewed
Mar 2, 2023
shibd
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The go implementation of PIP-165:apache/pulsar#15516
Modifications
ConnectionMaxIdleTime
toClientOptions
ConnectionPool
to period check and release idle connections.Verifying this change
This change added tests
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation