Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the minimum macOS version to 13 #239

Conversation

BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Jan 23, 2025

Currently the build workflow for macOS wheels run on macos-14 runner so that the wheel's target macOS version is 14. This is because the -mmacosx-version-min option is not specified when building Python from source.

You can find the following log in https://github.com/apache/pulsar-client-python/actions/runs/12878584451/job/35904753892

checking which MACOSX_DEPLOYMENT_TARGET to use... 14.7

We need to add MACOSX_DEPLOYMENT_TARGET as the environment variable, see https://github.com/python/cpython/blob/ec91e1c2762412f1408b0dfb5d281873b852affe/configure#L10759

Here we set it with 13 because 13 is the current minimum maintained version, see https://en.wikipedia.org/wiki/MacOS_version_history

@BewareMyPower BewareMyPower self-assigned this Jan 23, 2025
@BewareMyPower BewareMyPower added the bug Something isn't working label Jan 23, 2025
@BewareMyPower BewareMyPower added this to the 3.6.0 milestone Jan 23, 2025
@BewareMyPower BewareMyPower marked this pull request as draft January 23, 2025 15:42
@BewareMyPower BewareMyPower marked this pull request as ready for review January 23, 2025 15:55
@BewareMyPower
Copy link
Contributor Author

I opened a twin PR here: BewareMyPower#8. The wheels from the latest workflow (https://github.com/BewareMyPower/pulsar-client-python/actions/runs/12932986028) can be installed on my macOS 13.6 laptop.

% unzip wheel-mac-py3.12.zip 
Archive:  wheel-mac-py3.12.zip
  inflating: pulsar_client-3.6.0a1-cp312-cp312-macosx_13_0_universal2.whl  
% python3 --version
Python 3.12.2
% sw_vers 
ProductName:		macOS
ProductVersion:		13.6.3
BuildVersion:		22G436
% python3 -m pip install pulsar_client-3.6.0a1-cp312-cp312-macosx_13_0_universal2.whl 
Processing ./pulsar_client-3.6.0a1-cp312-cp312-macosx_13_0_universal2.whl
Requirement already satisfied: certifi in /opt/homebrew/lib/python3.12/site-packages (from pulsar-client==3.6.0a1) (2024.12.14)
Installing collected packages: pulsar-client
Successfully installed pulsar-client-3.6.0a1
% python3 -c 'import pulsar; c = pulsar.Client("pulsar://localhost:6650"); c.close()'
2025-01-24 00:01:02.204 INFO  [0x1ff95a100] ClientImpl:666 | Closing Pulsar client with 0 producers and 0 consumers

@BewareMyPower
Copy link
Contributor Author

Processing /Users/runner/work/pulsar-client-python/pulsar-client-python/dist/pulsar_client-3.6.0a1-cp313-cp313-macosx_13_0_universal2.whl

The wheel from https://github.com/apache/pulsar-client-python/actions/runs/12932992297/job/36071074566?pr=239 is 13.0.

@BewareMyPower BewareMyPower merged commit e6800f8 into apache:main Jan 24, 2025
11 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/fix-macos-minimum-version branch January 24, 2025 03:20
BewareMyPower added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants