Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no stars #77

Merged
merged 2 commits into from
May 17, 2022
Merged

fix no stars #77

merged 2 commits into from
May 17, 2022

Conversation

runqi-zhao
Copy link

Complete five（Show GitHub Star NO） from apache/pulsar#15550
image

@Anonymitaet Anonymitaet requested a review from urfreespace May 16, 2022 07:46
@Anonymitaet
Copy link
Member

@urfreespace can you help review?

@Anonymitaet
Copy link
Member

@zrsaber can we keep the GitHub icon as shown in the issue?
image

@runqi-zhao
Copy link
Author

runqi-zhao commented May 16, 2022 •
edited
Loading

@AnonymitaetThis is ok, but it will cause the icon to be small, like this, is this ok?I don't think this one is as pretty as the label
image

@Anonymitaet
Copy link
Member

@zrsaber can we just keep the icon and NO. as exactly shown in the image? (leave GitHub out)
image

@runqi-zhao
Copy link
Author

runqi-zhao commented May 16, 2022 •
edited
Loading

@Anonymitaet This is ok,like this:
image

@Anonymitaet
Copy link
Member

@zrsaber yes, I'm fine with this design.

@Anonymitaet This is ok,like this: image

@runqi-zhao
Copy link
Author

@zrsaber yes, I'm fine with this design.

@Anonymitaet This is ok,like this: image

@Anonymitaet ok, I have changed, like this:
image

@Anonymitaet
Copy link
Member

LGTM. @urfreespace thoughts?

@urfreespace
Copy link
Member

LGTM, thanks @zrsaber

@urfreespace urfreespace merged commit b49e805 into apache:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urfreespace urfreespace urfreespace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runqi-zhao @Anonymitaet @urfreespace