[improve][broker] Make Consumer#equals more effective (#18662)

apache · Feb 8, 2023 · 31308c9 · 31308c9
1 parent 5c47e42
commit 31308c9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
@@ -895,7 +895,7 @@ public CompletableFuture<Void> checkPermissionsAsync() {
     public boolean equals(Object obj) {
         if (obj instanceof Consumer) {
             Consumer other = (Consumer) obj;
-            return Objects.equals(cnx.clientAddress(), other.cnx.clientAddress()) && consumerId == other.consumerId;
+            return consumerId == other.consumerId && Objects.equals(cnx.clientAddress(), other.cnx.clientAddress());
         }
         return false;
     }