-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Broker] Apply PolicyHierarchyValue to inactiveTopicPolicies #12687
Merged
codelipenghui
merged 2 commits into
apache:master
from
Jason918:opt_inactiveTopicPolicies
Nov 11, 2021
Merged
[Broker] Apply PolicyHierarchyValue to inactiveTopicPolicies #12687
codelipenghui
merged 2 commits into
apache:master
from
Jason918:opt_inactiveTopicPolicies
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot run-failure-checks |
#12675 If that's your test failure reason, you should have a rebase or merge |
1d1234c
to
a6d8d24
Compare
a6d8d24
to
3e58b80
Compare
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 11, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
2 tasks
23 tasks
23 tasks
equanz
added a commit
to equanz/pulsar
that referenced
this pull request
Aug 10, 2022
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#12658 introduced
PolicyHierarchyValue
to cache broker/namespace/topic level policy value.This pull request applied
PolicyHierarchyValue
to inactiveTopicPolicies, which can avoid some complex checking on updates and make it easier to understand.Modifications
Changed type of inactiveTopicPolicies to PolicyHierarchyValue.
Verifying this change
This change is already covered by existing tests, such as pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
Polish code, no documents needed.