[Tests] Fix flakiness issue when spying ServerCnx #13608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
eolivelli,
315157973 and
michaeljmarshall
BewareMyPower
approved these changes
Jan 4, 2022
michaeljmarshall
approved these changes
Jan 4, 2022
wuzhanpeng
pushed a commit
to wuzhanpeng/pulsar
that referenced
this pull request
Jan 5, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jan 6, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13570
Motivation
For some reason
spy(new ServerCnx(pulsar))is flaky and fails with NPE in the ServerCnx constructor. The full stacktrace can be seen in #13570 description.Modifications
The alternative solution is to use
mock(ServerCnx.class, withSettings() .useConstructor(pulsar) .defaultAnswer(CALLS_REAL_METHODS))and the expectation is that the NPE wouldn't occur in this case.