Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 13756][Broker] Optimize topic policy with HierarchyTopicPolicies about dispatchRate #14038

Merged
merged 1 commit into from
Feb 24, 2022
Merged

[Issue 13756][Broker] Optimize topic policy with HierarchyTopicPolicies about dispatchRate #14038

merged 1 commit into from
Feb 24, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jan 29, 2022 •
edited
Loading

Master Issue: #13756

Motivation

See issue: #13756

Modifications

  • Add field dispatchRate in org.apache.pulsar.common.policies.data.HierarchyTopicPolicies
  • Methods to update dispatchRate in org.apache.pulsar.broker.service.AbstractTopic
  • Other Modifications are concerning on org.apache.pulsar.broker.service.persistent.DispatchRateLimiter where dispatchRate are used

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2022
@AnonHxy AnonHxy changed the title Optimize topic policy with HierarchyTopicPolicies about dispatchRate [Issue 13756][Broker] Optimize topic policy with HierarchyTopicPolicies about dispatchRate Jan 29, 2022
Jason918
Jason918 reviewed Jan 29, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a unit test for this.

pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java Outdated Show resolved Hide resolved
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 1, 2022

/pulsarbot run-failure-checks

@AnonHxy AnonHxy force-pushed the opt_dispatchRate branch 2 times, most recently from f66ec1f to 8b74270 Compare February 1, 2022 15:53
@Jason918
Copy link
Contributor

Jason918 commented Feb 2, 2022

/pulsarbot run-failure-checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 2, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 7, 2022
315157973
315157973 previously approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, please take a look at penghui's comment

@Jason918 Jason918 mentioned this pull request Feb 8, 2022
Closed
23 tasks
@apache apache deleted a comment from AnonHxy Feb 8, 2022
@Jason918
Copy link
Contributor

Jason918 commented Feb 8, 2022

@codelipenghui PTAL

@sijie sijie mentioned this pull request Feb 8, 2022
Closed
23 tasks
@codelipenghui codelipenghui removed this from the 2.10.0 milestone Feb 8, 2022
@AnonHxy AnonHxy force-pushed the opt_dispatchRate branch 2 times, most recently from ebc4b08 to ab16e7e Compare February 9, 2022 07:19
Jason918
Jason918 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 9, 2022

@eolivelli Could you please help review this PR~

@Jason918
Copy link
Contributor

@codelipenghui PTAL

@AnonHxy AnonHxy force-pushed the opt_dispatchRate branch 4 times, most recently from de10fa0 to f9297ea Compare February 15, 2022 03:07
Jason918
Jason918 previously approved these changes Feb 15, 2022
View reviewed changes
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 15, 2022

/pulsarbot run-failure-checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 17, 2022

/pulsarbot run-failure-checks

1 similar comment
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 17, 2022

/pulsarbot run-failure-checks

Jason918
Jason918 previously approved these changes Feb 17, 2022
View reviewed changes
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 17, 2022

resolve conflicting

@Jason918
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 009da3f into apache:master Feb 24, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@AnonHxy
Optimize topic policy with HierarchyTopicPolicies about dispatchRate (a…
e77e4a8 
…pache#14038)
AnonHxy added a commit to AnonHxy/pulsar that referenced this pull request Jul 25, 2022
@AnonHxy
Optimize topic policy with HierarchyTopicPolicies about dispatchRate (a…
a0875fd 
…pache#14038)
@AnonHxy AnonHxy mentioned this pull request Jul 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@Jason918 Jason918 Jason918 approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@315157973 315157973 Awaiting requested review from 315157973

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AnonHxy @Jason918 @315157973 @codelipenghui