Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscriptionDispatchRate #14151

Merged
merged 1 commit into from
Feb 14, 2022
Merged

[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscriptionDispatchRate #14151

merged 1 commit into from
Feb 14, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Feb 7, 2022

Master Issue: #13756

Motivation

See issue: #13756

Modifications

  • Add field subscriptionDispatchRate in org.apache.pulsar.common.policies.data.HierarchyTopicPolicies
  • Methods to update subscriptionDispatchRate in org.apache.pulsar.broker.service.AbstractTopic
  • Other Modifications are concerning on org.apache.pulsar.broker.service.persistent.DispatchRateLimiter where subscriptionDispatchRate are used

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 7, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 8, 2022

/pulsarbot run-failure-checks

@Jason918 Jason918 mentioned this pull request Feb 8, 2022
Closed
23 tasks
@Jason918 Jason918 changed the title [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscriptionD… [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscriptionDispatchRate Feb 8, 2022
@Jason918 Jason918 self-requested a review February 8, 2022 04:14
@sijie sijie mentioned this pull request Feb 8, 2022
Closed
23 tasks
@AnonHxy AnonHxy force-pushed the opt_subscriptionDispatchRate branch 3 times, most recently from 61b753b to 53ebbe4 Compare February 10, 2022 08:44
Jason918
Jason918 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left some minor comments.

...va/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java Outdated Show resolved Hide resolved
...va/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java Outdated Show resolved Hide resolved
@AnonHxy AnonHxy force-pushed the opt_subscriptionDispatchRate branch from 53ebbe4 to 43532e0 Compare February 10, 2022 13:03
@AnonHxy AnonHxy force-pushed the opt_subscriptionDispatchRate branch from 43532e0 to f2cfe3c Compare February 10, 2022 16:16
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 11, 2022

@Jason918 PTAL

@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 14, 2022
@codelipenghui codelipenghui merged commit 7cbd849 into apache:master Feb 14, 2022
@lhotari lhotari mentioned this pull request Feb 15, 2022
Closed
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@AnonHxy
Optimize topic policy with HierarchyTopicPolicies about subscriptionD…
2c046d3 
…ispatchRate (apache#14151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@315157973 315157973 Awaiting requested review from 315157973

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AnonHxy @Jason918 @codelipenghui