[Broker] Move schema compatibility strategy cmd from topics to topicPolicies #14225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
michaeljmarshall
requested changes
Feb 10, 2022
michaeljmarshall
requested review from
eolivelli,
codelipenghui and
315157973
Jason918
reviewed
Feb 11, 2022
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Show resolved
Hide resolved
|
Hi @momo-jun can you follow up on the doc change? Thanks |
Sure, I will take care of it. |
nodece
force-pushed
the
move_schema_compatibility_strategy_cmd
branch
from
a3d7237 to
61fa7d2
Compare
|
/pulsarbot rerun-failure-checks |
1 task
|
Hi @nodece since this PR contains doc changes on https://pulsar.apache.org/tools/pulsar-admin/2.10.0-SNAPSHOT/#topicpolicies, please label this kind of PR w/ |
Anonymitaet
added
doc
nodece
force-pushed
the
move_schema_compatibility_strategy_cmd
branch
from
61fa7d2 to
3a0abba
Compare
|
@Anonymitaet Thanks. |
nodece
changed the title
nodece
force-pushed
the
move_schema_compatibility_strategy_cmd
branch
from
3a0abba to
a1aeed5
Compare
...a/org/apache/pulsar/tests/integration/cli/topicpolicies/SchemaCompatibilityStrategyTest.java
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
3 similar comments
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
codelipenghui
added
the
release/blocker
codelipenghui
previously approved these changes
Feb 14, 2022
Jason918
previously approved these changes
Feb 14, 2022
315157973
previously approved these changes
Feb 14, 2022
RobertIndie
previously approved these changes
Feb 14, 2022
|
@michaeljmarshall Please help review this PR again. |
michaeljmarshall
requested changes
Feb 14, 2022
There was a problem hiding this comment.
I think the annotations may be incorrect. Can you take a look @nodece? Thanks.
...a/org/apache/pulsar/tests/integration/cli/topicpolicies/SchemaCompatibilityStrategyTest.java
Outdated
Show resolved
Hide resolved
…olicies Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
move_schema_compatibility_strategy_cmd
branch
from
4078ec1 to
a4ba12d
Compare
michaeljmarshall
approved these changes
Feb 15, 2022
|
/pulsarbot rerun-failure-checks |
nodece
requested review from
codelipenghui,
315157973,
Jason918 and
michaeljmarshall
congbobo184
dismissed stale reviews from RobertIndie, 315157973, Jason918, and codelipenghui
via
a4ba12d
codelipenghui
approved these changes
Feb 16, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
schema-compatibility-strategycmd should be in thetopicPoliciessubcommand, it is topic policies.Modifications
Documentation
Need to update docs?
doc-required- [Doc] Move schema compatibility strategy CMD from topics to topicsPolicies #14232Need to update the
pulsar-admin topics *-schema-compatibility-strategy->pulsar-admin topicPolicies *-schema-compatibility-strategy