Migrate Docker images and CI to Java 17 #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
|
@nicoloboschi Please rebase this PR |
nicoloboschi
force-pushed
the
task/ci-jdk17
branch
from
40dc096 to
1880873
Compare
|
/pulsarbot rerun-failure-checks |
merlimat
approved these changes
Apr 2, 2022
lhotari
approved these changes
Apr 3, 2022
lhotari
requested review from
codelipenghui,
315157973,
addisonj,
aloyszhang,
BewareMyPower,
congbobo184,
dave2wave,
freeznet and
gaoran10
lhotari
requested review from
hangc0276,
Jason918,
michaeljmarshall,
RobertIndie,
hezhangjian,
Technoboy-,
dlg99 and
eolivelli
|
Hi nicoloboschi, I am definitely a latecomer to this issue, but I think we could also support java17 build as well as this java17 runtime support. I added this java17 build support and created a pip here, #15207. I can help with upgrading the build for java17 and adding the different jdk compatibility tests (if not done yet). |
freeznet
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal is to run Pulsar using JDK17 at runtime, benefitting from the latest JVM performance improvements and features.
In order to do that we need to run all the tests using JDK17.
The goal is NOT to deprecate JDK8 or JDK11 runtime compatibility. The java compiler release flag doesn't change.
Modifications
Verifying this change
All the CI jobs are passing
Manual tests are encouraged, mainly around
pulsar-ioconnectors since we don't have integration tests for all the connectors.Documentation
docAdded the support for JDK17 in the installation page.