Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Make some methods of BrokersBase pure async. #15281

Merged
merged 4 commits into from
Apr 27, 2022
Merged

[improve][broker] Make some methods of BrokersBase pure async. #15281

merged 4 commits into from
Apr 27, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

See PIP #14365 and change tracker #15043.

Modifications

  • Make BrokersBase getRuntimeConfiguration/getInternalConfigurationData/backlogQuotaCheck methods to pure async.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc
    (Please explain why)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 24, 2022
@mattisonchao mattisonchao mentioned this pull request Apr 24, 2022
Closed
26 tasks
Jason918
Jason918 approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao changed the title [improve][broker] PIP-149 Make some methods of BrokersBase pure async. [improve][broker] Make some methods of BrokersBase pure async. Apr 24, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Apr 25, 2022
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@mattisonchao mattisonchao requested a review from Technoboy- April 26, 2022 00:33
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@mattisonchao mattisonchao requested a review from Technoboy- April 27, 2022 00:58
@Technoboy- Technoboy- merged commit a0c2c59 into apache:master Apr 27, 2022
@sijie sijie mentioned this pull request Aug 1, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hezhangjian hezhangjian hezhangjian approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@Jason918 Jason918 Jason918 approved these changes

Assignees

@mattisonchao mattisonchao

Labels
area/broker doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mattisonchao @Jason918 @Technoboy- @codelipenghui @hezhangjian