Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker]Make SubscriptionExpirationTime method async #16328

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

gaozhangmin
Copy link
Contributor

@gaozhangmin gaozhangmin commented Jul 1, 2022

Motivation

See PIP #14365 and change tracker #15043.

Make the below method async:
getSubscriptionExpirationTime
setSubscriptionExpirationTime
removeSubscriptionExpirationTime

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-not-needed

@gaozhangmin gaozhangmin requested review from codelipenghui, mattisonchao and nodece and removed request for codelipenghui, mattisonchao and nodece July 1, 2022 09:37
@gaozhangmin gaozhangmin self-assigned this Jul 1, 2022
@gaozhangmin gaozhangmin added this to the 2.11.0 milestone Jul 1, 2022
@gaozhangmin gaozhangmin added doc-not-needed Your PR changes do not impact docs area/admin type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jul 1, 2022
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants