[improve][broker] add limitStatsLogging configuration when enabling bookkeeperClientExposeStatsToPrometheus #16734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel_bookie_client metrics of bkclient stats
TakaHiR07
changed the title
codelipenghui
added
type/enhancement
|
@TakaHiR07 Please provide a correct documentation label for your PR. |
@codelipenghui I add an unit test and doc of this configuration. Please take a look |
|
The pr had no activity for 30 days, mark with Stale label. |
tisonkun
changed the title
github-actions
bot
added
doc
tisonkun
approved these changes
Dec 9, 2022
Signed-off-by: tison <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #16734 +/- ##
============================================
- Coverage 47.92% 39.38% -8.55%
+ Complexity 10679 8260 -2419
============================================
Files 703 703
Lines 68831 68838 +7
Branches 7378 7379 +1
============================================
- Hits 32988 27111 -5877
- Misses 32119 38304 +6185
+ Partials 3724 3423 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging... |
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
…kkeeperClientExposeStatsToPrometheus (apache#16734) Signed-off-by: tison <[email protected]> Co-authored-by: fanjianye <[email protected]> Co-authored-by: tison <[email protected]>
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
…kkeeperClientExposeStatsToPrometheus (apache#16734) Signed-off-by: tison <[email protected]> Co-authored-by: fanjianye <[email protected]> Co-authored-by: tison <[email protected]>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…kkeeperClientExposeStatsToPrometheus (apache#16734) Signed-off-by: tison <[email protected]> Co-authored-by: fanjianye <[email protected]> Co-authored-by: tison <[email protected]>
momo-jun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This closes #16732.
Modifications
Add bookkeeperClientLimitStatsLogging configuration for broker.conf
After enable bookkeeperClientExposeStatsToPrometheus and bookkeeperClientLimitStatsLogging, there are no more per_channel_bookie_client metrics in bookie client stats.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc