[refactor][c++ client] Enable client memory limit controller by default. #16903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
changed the title
RobertIndie
approved these changes
Aug 2, 2022
BewareMyPower
requested changes
Aug 2, 2022
There was a problem hiding this comment.
Currently we cannot disable maxPendingMessages for C++ client, see the failed tests. In addition, C++ client doesn't implement memory limit for consumer. We need to implement PIP-74 for C++ client before that.
Even for producer, there was an issue for memory limit, see #11910. You can verify this issue first.
I get it, thanks. I will perfect the memory limit first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#13306
Modifications
.cmakefolderDocumentation
doc-not-needed(Please explain why)