[feat][broker]PIP-180 ShadowTopic - Part III - Add shadowTopics in TopicPolicy #17242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason918
changed the title
|
/pulsarbot run-failure-checks |
Jason918
force-pushed
the
pip-180.3
branch
2 times, most recently
from
a41a585 to
cfa37a4
Compare
eolivelli
requested changes
Aug 24, 2022
| @@ -4236,5 +4236,84 @@ public void setSchemaValidationEnforced(@Suspended AsyncResponse asyncResponse, | |||
| }); | |||
| } | |||
|
|
|||
| @GET | |||
| @Path("/{tenant}/{namespace}/{topic}/shadowTopic") | |||
There was a problem hiding this comment.
Should the name be 'plural' ? shadowTopics
There was a problem hiding this comment.
@eolivelli Make sense, addressed.
AnonHxy
approved these changes
Aug 26, 2022
|
LGTM |
update REST endpoints fix test
|
@eolivelli PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16153
Motivation
Source topic need to know its shadow topic list to start the ShadowReplicators.
Note: Shadow topic also need to know its source topic, but it can't implemented with topic policy. Because topic policy can only guarantee eventual consistency and shadow topic must know its source topic during initialization.
Modifications
Add shadowTopics in TopicPolicy and create/delete/get commands in admin clients.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-completeDoc added in pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java