[improve][doc] Improve golang client doc #17455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
|
Comment for a cross-reference to #17302. |
labuladong
changed the title
Anonymitaet
reviewed
Sep 5, 2022
nodece
reviewed
Sep 5, 2022
nodece
reviewed
Sep 5, 2022
nodece
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Overall this PR looks good to me, I noticed we added some configurable parameters on this page.
I suggest link to https://pkg.go.dev/github.com/apache/pulsar-client-go/pulsar
Co-authored-by: Zixuan Liu <[email protected]>
Co-authored-by: Zixuan Liu <[email protected]>
|
Thanks for your suggestion. Links added. @nodece |
RobertIndie
reviewed
Sep 6, 2022
nodece
approved these changes
Sep 6, 2022
Anonymitaet
reviewed
Sep 6, 2022
Co-authored-by: Anonymitaet <[email protected]>
Co-authored-by: Anonymitaet <[email protected]>
Co-authored-by: Anonymitaet <[email protected]>
RobertIndie
approved these changes
Sep 6, 2022
Anonymitaet
approved these changes
Sep 6, 2022
tisonkun
reviewed
Sep 6, 2022
|
Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected? If not yet, please preview your changes locally and attach the screenshots in the PR description to let others know. In this way, you can get your PR merged more quickly. Thanks! |
tisonkun
approved these changes
Sep 6, 2022
|
Screenshots of this PR:
PTAL @Anonymitaet |
|
@labuladong thanks! Feel free to ping me to merge this PR after all tests pass. |
momo-jun
reviewed
Sep 6, 2022
Co-authored-by: momo-jun <[email protected]>
momo-jun
approved these changes
Sep 7, 2022
urfreespace
approved these changes
Sep 7, 2022
|
ping @Anonymitaet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17397
Motivation
Fix some errors in the Golang doc and improve code demos.
Modifications
Update some out-of-date API interfaces and make all code snippets can run.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)