-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][doc] Improve the information architecture of the security chapter #17615
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4fd677f
Sidebar re-org
momo-jun e4b7fcf
Separate TLS encryption/authentication using Keystore to parent topics
momo-jun 0a1ff96
use language-specific tabs to show code snippets
momo-jun 105b468
streamline headings
momo-jun e2d48d8
Update client-libraries-java.md
momo-jun bd7f97d
Add code snippet for python clients to support #17482
momo-jun 01d1002
Add code snippet for go clients
momo-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
###
instead of####
?Other headings are in the format of "Verb + xxx" while this heading is not.
Consider keeping consistent or turning this section into other content formats (like moving lines 97 - 100 to line 74)?
So that users know the relationship between the section
Configure Athenz authentication in Pulsar clients
andSupported pattern formats
(the info in
Supported pattern format
can be a part ofConfigure Athenz authentication in Pulsar clients
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copied and pasted here from another topic. I guess the intention was kind of to be a reference sub-topic so that's why
####
was used (not shown in the hot links). Thanks for the reminder. It will be evaluated in a further review throughout the topic.