-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker]PIP-255 Part-1: Add listener interface for namespace service #20406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #20406 +/- ##
============================================
+ Coverage 72.45% 72.92% +0.47%
- Complexity 31898 31904 +6
============================================
Files 1852 1867 +15
Lines 138227 138486 +259
Branches 15175 15202 +27
============================================
+ Hits 100150 100989 +839
+ Misses 30098 29489 -609
- Partials 7979 8008 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
This is a feature PR and introduces a new interface. Why do we cherry-pick it to branch-3.0? @Technoboy- |
(cherry picked from commit f3bb89d)
(cherry picked from commit f3bb89d)
(cherry picked from commit f3bb89d)
PIP: #19806
Motivation
Modifications
In PIP-219, we want to make the partition assignment strategy pluggable.
First, we need to add listener interface for namespace service
Verifying this change
Documentation
doc-not-needed
Matching PR in forked repository