-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ws] Support subscribing multi/pattern topic for Websocket #21379
Merged
Technoboy-
merged 5 commits into
apache:master
from
Technoboy-:support-multi-topic-consume-for-ws
Nov 6, 2023
Merged
[improve][ws] Support subscribing multi/pattern topic for Websocket #21379
Technoboy-
merged 5 commits into
apache:master
from
Technoboy-:support-multi-topic-consume-for-ws
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/MultiTopicConsumerHandler.java
Outdated
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTest.java
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java
Outdated
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/MultiTopicConsumerHandler.java
Outdated
Show resolved
Hide resolved
mattisonchao
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal LGTM.
Please help fix the checkstyle issue. |
mattisonchao
approved these changes
Oct 26, 2023
59e07f7
to
6caf1ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #21379 +/- ##
=============================================
+ Coverage 34.54% 73.25% +38.71%
- Complexity 12084 32609 +20525
=============================================
Files 1713 1892 +179
Lines 130782 140444 +9662
Branches 14250 15436 +1186
=============================================
+ Hits 45173 102878 +57705
+ Misses 79577 29475 -50102
- Partials 6032 8091 +2059
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-307
Motivation
Support subscribing multi/pattern topic for WS.
The new sub-path could be :
Documentation
doc
doc-required
doc-not-needed
doc-complete