Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Support not retaining null-key message during topic compaction (#21578) #21665

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Dec 4, 2023

Motivation & Modifications

Cherry-pick #21578 into branch-2.11 with topicCompactionRetainNullKey=true default.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 4, 2023
@coderzc coderzc added release/2.11.4 ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Dec 4, 2023
@coderzc coderzc closed this Dec 4, 2023
@coderzc coderzc reopened this Dec 4, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 4, 2023
@coderzc coderzc force-pushed the cherry-pick/2.11/21578 branch 3 times, most recently from 5d19c00 to 010117f Compare December 7, 2023 07:46
@coderzc coderzc self-assigned this Dec 7, 2023
@coderzc coderzc force-pushed the cherry-pick/2.11/21578 branch 3 times, most recently from 4b20c60 to 91efee2 Compare December 13, 2023 08:35
@coderzc coderzc force-pushed the cherry-pick/2.11/21578 branch from 91efee2 to 5276f7b Compare December 13, 2023 09:20
@Technoboy- Technoboy- merged commit cd5fa17 into apache:branch-2.11 Dec 14, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants