Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build][branch-3.1] Fix Pulsar SQL LICENSE file #22192

Closed

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Mar 4, 2024

Motivation

The #22144 upgraded jetty to 9.4.54.v20240208 to address CVE-2024-22201.
The branch-3.1 still maintains the Pulsar SLQ, it introduces some issues with LICENSE/NOTICE.

➜  pulsar git:(branch-3.1) ✗ src/check-binary-license.sh distribution/server/target/apache-pulsar-3.1.3-bin.tar.gz
http2-client-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
http2-common-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
http2-hpack-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
http2-http-client-transport-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
http2-server-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-alpn-client-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-alpn-java-client-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-client-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-http-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-http-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-io-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-io-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-jmx-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-security-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-security-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-server-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-server-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-servlet-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-servlet-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-util-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-util-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-util-ajax-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
jetty-util-ajax-9.4.54.v20240208.jar unaccounted for in trino/LICENSE
http2-client-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
http2-common-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
http2-hpack-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
http2-http-client-transport-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-alpn-client-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
http2-server-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-alpn-java-client-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-client-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-http-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-io-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-jmx-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-security-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-server-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-servlet-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-util-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled
jetty-util-ajax-9.4.53.v20231009.jar mentioned in trino/LICENSE, but not bundled

It looks like there are issues with the LICENSE/NOTICE.

Modifications

Fix the Pulsar SQL LICENSE file.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 4, 2024
@gaoran10 gaoran10 self-assigned this Mar 4, 2024
@gaoran10 gaoran10 requested a review from lhotari March 4, 2024 18:09
@lhotari
Copy link
Member

lhotari commented Mar 4, 2024

I didn't notice this PR, fixed this problem directly by commit 7e28e84

@lhotari lhotari closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test release/3.1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants