[improve][broker] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering #23352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
the
category/reliability
lhotari
requested review from
merlimat,
dlg99,
eolivelli,
equanz,
codelipenghui,
dao-jun,
hrsakai,
poorbarcode and
shibd
github-actions
bot
added
the
doc-required
4 tasks
lhotari
force-pushed
the
lh-pip-379-implementation
branch
2 times, most recently
from
923f379 to
48b2022
Compare
lhotari
force-pushed
the
lh-pip-379-implementation
branch
2 times, most recently
from
1855f33 to
a6d9bf3
Compare
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java
Outdated
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Oct 8, 2024
- it's used for quick profiling
poorbarcode
reviewed
Oct 8, 2024
.../apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Show resolved
Hide resolved
.../apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Show resolved
Hide resolved
This was referenced Oct 8, 2024
Merged
equanz
reviewed
Oct 11, 2024
.../apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Show resolved
Hide resolved
This was referenced Oct 11, 2024
[Bug][PIP-379] Hash ranges should not move from one consumer to another when a consumer joins
#23439
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23307
Fixes #21199
Fixes #15705
Fixes #21656
Fixes #20899
Fixes #20885
Implementation for PIP-379: Key_Shared Draining Hashes for Improved Message Ordering
Mailing list discussion about this PR
4.0.x docs for the implementation: https://pulsar.apache.org/docs/4.0.x/concepts-messaging/#preserving-order-of-message-delivery-by-key
Motivation
See PIP-379: Key_Shared Draining Hashes for Improved Message Ordering
PIP-379 aims to address several issues with the current implementation and introduce a more efficient mechanism for managing message ordering.
Problem:
The current Key_Shared implementation faces challenges including:
PIP-379 introduces a "draining hashes" concept to efficiently manage
message ordering by tracking affected hashes when consumer assignments
change.
Benefits:
This proposal would replace the existing "recently joined consumers"
mechanism, addressing its limitations while providing a more robust
solution.
Modifications
See PIP-379: Key_Shared Draining Hashes for Improved Message Ordering for high level design with simplified code examples.
Documentation
docdoc-requireddoc-not-neededdoc-complete