Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] PIP-393: Support configuring NegativeAckPrecisionBitCnt while building consumer. #23804

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Jan 3, 2025

Implementation PR for PIP-393: #23601.

Motivation

PR #23600 has implemented most of the logic, but lack of support for configuring NegativeAckPrecisionBitCnt by mistake.

Modifications

Add support for configuring NegativeAckPrecisionBitCnt while building consumer.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#68

Copy link
Member

@crossoverJie crossoverJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Could you please add unit test for client?

Copy link
Contributor

@poorbarcode poorbarcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a test for this change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (bbc6224) to head (a959d0c).
Report is 832 commits behind head on master.

Files with missing lines Patch % Lines
...apache/pulsar/client/impl/ConsumerBuilderImpl.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23804      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.66%     
+ Complexity    32624    31819     -805     
============================================
  Files          1877     1853      -24     
  Lines        139502   143453    +3951     
  Branches      15299    16290     +991     
============================================
+ Hits         102638   106504    +3866     
+ Misses        28908    28576     -332     
- Partials       7956     8373     +417     
Flag Coverage Δ
inttests 26.80% <0.00%> (+2.22%) ⬆️
systests 23.16% <0.00%> (-1.16%) ⬇️
unittests 73.76% <66.66%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apache/pulsar/client/impl/ConsumerBuilderImpl.java 86.66% <66.66%> (-0.28%) ⬇️

... and 1030 files with indirect coverage changes

@thetumbled
Copy link
Member Author

thetumbled commented Jan 3, 2025

How about adding a test for this change?

Added.

@thetumbled thetumbled merged commit f199e88 into apache:master Jan 3, 2025
52 checks passed
@lhotari
Copy link
Member

lhotari commented Jan 3, 2025

@thetumbled Please don't add cherry-picked labels before a change has been cherry-picked. I can handle the cherry-picking for this PR. There are some details about the process at https://pulsar.apache.org/contribute/maintenance-process/ .

lhotari pushed a commit that referenced this pull request Jan 3, 2025
…tCnt while building consumer. (#23804)

(cherry picked from commit f199e88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants