-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] PIP-393: Support configuring NegativeAckPrecisionBitCnt while building consumer. #23804
[improve][client] PIP-393: Support configuring NegativeAckPrecisionBitCnt while building consumer. #23804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Could you please add unit test for client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a test for this change?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23804 +/- ##
============================================
+ Coverage 73.57% 74.24% +0.66%
+ Complexity 32624 31819 -805
============================================
Files 1877 1853 -24
Lines 139502 143453 +3951
Branches 15299 16290 +991
============================================
+ Hits 102638 106504 +3866
+ Misses 28908 28576 -332
- Partials 7956 8373 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
Outdated
Show resolved
Hide resolved
Added. |
@thetumbled Please don't add |
Implementation PR for PIP-393: #23601.
Motivation
PR #23600 has implemented most of the logic, but lack of support for configuring
NegativeAckPrecisionBitCnt
by mistake.Modifications
Add support for configuring
NegativeAckPrecisionBitCnt
while building consumer.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#68