[fix][misc] Honor dynamic log levels in log4j2.yaml #23847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the log levels (
pulsar.log.level
andpulsar.log.root.level
) are modified in theconf/log4j2.yaml
during runtime, the change is not reflected in the logs as expected.I found the pulsar script always passes the
pulsar.log.level
andpulsar.log.root.level
, which led to this issue.Modifications
pulsar/Dockerfile
.-Dpulsar.log.level
only ifPULSAR_LOG_LEVEL
is defined.-Dpulsar.log.root.level
only ifPULSAR_LOG_ROOT_LEVEL
is defined, and ensuredPULSAR_LOG_ROOT_LEVEL
fallback toPULSAR_LOG_LEVEL
if not defined.Documentation
doc
doc-required
doc-not-needed
doc-complete