[fix][test]Fix flaky test testTopicUnloadAfterSessionRebuild #23852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
release/3.0.9
release/3.3.5
release/4.0.3
and removed
doc-not-needed
|
/pulsarbot rerun-failure-checks |
shibd
approved these changes
Jan 15, 2025
lhotari
approved these changes
Jan 16, 2025
dao-jun
approved these changes
Jan 16, 2025
lhotari
pushed a commit
that referenced
this pull request
Jan 16, 2025
(cherry picked from commit b3641f0)
lhotari
pushed a commit
that referenced
this pull request
Jan 17, 2025
(cherry picked from commit b3641f0)
lhotari
pushed a commit
that referenced
this pull request
Jan 17, 2025
(cherry picked from commit b3641f0)
poorbarcode
added a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23389
Motivation
pulsar1.getBrokerService().getTopic(topicName, false)may return acompleted empty future, but the verifyassertTrue(future == null || future.isCompletedExceptionally())does not matchModifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x