RATIS-1632. Upgrade gRPC to 1.48.1 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adoroszlai , why updating the versions? BTW, there is a recent gRPC "ByteBuffer memory leak in retry mechanism" issue; see grpc/grpc-java#9340 . I wonder if we should wait for it. See also https://lists.apache.org/thread/j7ovtqor4do39z4yfps0fvp3hhgncotn |
|
@szetszwo Sorry, I was under the impression that 4.1.77 has a CVE, but actually it is the one to fix the CVE. So we can close this for now, waiting for gRPC with the fix for memleak. |
adoroszlai
changed the title
szetszwo
approved these changes
Aug 3, 2022
|
Thanks @szetszwo for reviewing and committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade gRPC to 1.48.0, Netty to 4.1.79 in Ratis Thirdparty.Upgrade gRPC to 1.48.1.
https://issues.apache.org/jira/browse/RATIS-1632
How was this patch tested?
Regular CI:
https://github.com/adoroszlai/ratis-thirdparty/runs/7451209538?check_suite_focus=truehttps://github.com/adoroszlai/ratis-thirdparty/runs/7654050988?check_suite_focus=true
Ran Ratis unit tests with local build of Ratis Thirdparty.TestRaftReconfigurationWithGrpcfailed both with and without the change, otherwise OK.