Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2169. mvnw test: Corrupted STDOUT by directly writing to native stream in forked JVM 1 #1162

Merged
merged 2 commits into from
Oct 7, 2024
Merged

RATIS-2169. mvnw test: Corrupted STDOUT by directly writing to native stream in forked JVM 1 #1162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed7e39
RATIS-2169. mvnw test: Corrupted STDOUT by directly writing to native…
szetszwo Oct 7, 2024
967315a
Revert maven-surefire-plugin.version
szetszwo Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
<maven-checkstyle-plugin.version>3.3.0</maven-checkstyle-plugin.version>
<maven-clover2-plugin.version>4.0.6</maven-clover2-plugin.version>
<maven-pdf-plugin.version>1.6.1</maven-pdf-plugin.version>
<maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
<maven-surefire-plugin.version>3.5.1</maven-surefire-plugin.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions newer than 3.0.0-M4 are affected by https://issues.apache.org/jira/browse/SUREFIRE-1722

Maybe we have to decide which bug to live with ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Let's remain in 3.0.0-M4 then.

<wagon-ssh.version>3.5.3</wagon-ssh.version>
<hadoop-maven-plugins.version>3.4.0</hadoop-maven-plugins.version>

Expand Down Expand Up @@ -223,8 +223,8 @@
<testsThreadCount>4</testsThreadCount>

<slf4j.version>2.0.7</slf4j.version>
<junit.jupiter.version>5.10.1</junit.jupiter.version>
<jacoco.version>0.8.11</jacoco.version>
<junit-bom.version>5.11.2</junit-bom.version>
<jacoco.version>0.8.12</jacoco.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the comments on stack overflow:

upgrading jacoco-plugin from 0.8.1 to 0.8.4 did the job

But we already have 0.8.11, which is newer than both, so I guess this won't fix the problem.

We can upgrade anyway, Ozone has been using 0.8.12 for 6 months now (HDDS-10660).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also aware that. Just wonder they might have a better fix in a newer version.

</properties>

<dependencyManagement>
Expand Down Expand Up @@ -427,7 +427,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.jupiter.version}</version>
<version>${junit-bom.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Loading