Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove boost from StringIdMaker, and fixed some bugs. #183

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

ifplusor
Copy link
Contributor

What is the purpose of the change

remove boost from StringIdMaker, and fixed some bugs.

Brief changelog

  1. remove boost from StringIdMaker;
  2. fixed byte order bug;
  3. fixed bug in setStartTime

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added this to the 1.2.4 milestone Nov 11, 2019
@ShannonDing ShannonDing added bug Something isn't working enhancement New feature or request labels Nov 11, 2019
@ShannonDing ShannonDing merged commit dbbc155 into apache:master Nov 11, 2019
@ifplusor ifplusor deleted the fixed-StringIdMaker branch December 31, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants