Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(producer): Support user data in async callback #193

Merged
merged 1 commit into from
Sep 25, 2019
Merged

feat(producer): Support user data in async callback #193

merged 1 commit into from
Sep 25, 2019

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

Support user data in async callback

Brief changelog

typedef void (COnSendSuccessCallback)(CSendResult result, CMessage msg, void* userData);
typedef void (COnSendExceptionCallback)(CMQException e, CMessage msg, void* userData);
ROCKETMQCLIENT_API int SendAsync(CProducer* producer,
CMessage* msg,
COnSendSuccessCallback cSendSuccessCallback,
COnSendExceptionCallback cSendExceptionCallback,
void* userData);

Verifying this change

see the code

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the enhancement New feature or request label Sep 25, 2019
@ShannonDing ShannonDing added this to the 1.2.4 milestone Sep 25, 2019
@ShannonDing ShannonDing merged commit 2dfbb0c into apache:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant