Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: optimize memory copy in MemoryBlock by move constructor and move assignment. #70

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

ifplusor
Copy link
Contributor

optimize memory copy in MemoryBlock by move constructor and move assignment.

@jovany-wang
Copy link
Contributor

No need to change such many codes that looks like nothing different.

@ifplusor
Copy link
Contributor Author

No need to change such many codes that looks like nothing different.

CRLF -> LF

@jovany-wang
Copy link
Contributor

jovany-wang commented Jan 18, 2019

@ifplusor Thanks for your explanations.
I don't think we should change CRLF to LF in a feature change PR.
It will make us confused for your changes.

I think it's better to request another PR to do the CRLF change.
In this PR, just to do the Optimization, so that we could read what you changed.

@ifplusor
Copy link
Contributor Author

@ifplusor Thanks for your explanations.
I don't think we should to change CRLF to LF in a feature change PR.
It will make us confused for your changes.

@jovany-wang yeah, i will split commit.

@ifplusor ifplusor force-pushed the optimize-memoryblock branch from 721cf5a to fa8882e Compare January 18, 2019 03:19
@ifplusor ifplusor force-pushed the optimize-memoryblock branch from 71ffe5e to 9416767 Compare January 18, 2019 03:44
@ShannonDing ShannonDing added the enhancement New feature or request label Jan 21, 2019
@ShannonDing ShannonDing added this to the 1.2.2 milestone Jan 21, 2019
@ShannonDing ShannonDing merged commit 3b8509e into apache:master Feb 15, 2019
@ifplusor ifplusor deleted the optimize-memoryblock branch February 15, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants