Feat/rpc request #803
Merged
Feat/rpc request #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issue apache#778] Build instance name with nanosecond (apache#779)
…into feat/rpc-request
georgehao
force-pushed
the
feat/rpc-request
branch
from
f3cc81a to
7c0a165
Compare
githublaohu
reviewed
Apr 15, 2022
AlexStocks
approved these changes
May 26, 2022
duhenglucky
approved these changes
May 26, 2022
ShannonDing
reviewed
May 27, 2022
internal/request_response_future.go
Outdated
| func (rf *RequestResponseFuture) WaitResponseMessage(reqMsg *primitive.Message) (*primitive.Message, error) { | ||
| select { | ||
| case <-time.After(rf.Timeout): | ||
| err := fmt.Errorf("send request message to %s OK, but wait reply message timeout %d ms", reqMsg.Topic, rf.Timeout.Milliseconds()) |
There was a problem hiding this comment.
seem not supported in go 1.11 and go 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add RPC request-response