[ISSUE #935] C++ simple consumer should remove destructor (#938)

apache · Feb 11, 2025 · f117e73 · f117e73
1 parent 0425196
commit f117e73
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/cpp/examples/ExampleSimpleConsumer.cpp b/cpp/examples/ExampleSimpleConsumer.cpp
@@ -59,6 +59,7 @@ int main(int argc, char* argv[]) {
                              .withAwaitDuration(std::chrono::seconds(10))
                              .build();
 
+  // Should use while (true) instead
   for (int j = 0; j < 30; j++) {
     std::vector<MessageConstSharedPtr> messages;
     std::error_code ec;

diff --git a/cpp/include/rocketmq/SimpleConsumer.h b/cpp/include/rocketmq/SimpleConsumer.h
@@ -43,8 +43,6 @@ class SimpleConsumerBuilder;
 
 class SimpleConsumer {
 public:
-  ~SimpleConsumer();
-
   static SimpleConsumerBuilder newBuilder();
 
   void subscribe(std::string topic, FilterExpression filter_expression);

diff --git a/cpp/source/rocketmq/SimpleConsumer.cpp b/cpp/source/rocketmq/SimpleConsumer.cpp
@@ -33,10 +33,6 @@ SimpleConsumerBuilder SimpleConsumer::newBuilder() {
 SimpleConsumer::SimpleConsumer(std::string group) : impl_(std::make_shared<SimpleConsumerImpl>(group)) {
 }
 
-SimpleConsumer::~SimpleConsumer() {
-  impl_->shutdown();
-}
-
 void SimpleConsumer::start() {
   impl_->start();
 }