Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #82]Filter the system topic (clusterName+REPLY_TOPIC) when dashboard was making topic statistics #83

Merged
merged 1 commit into from
Apr 11, 2022
+3 −2
Merged

[ISSUE #82]Filter the system topic (clusterName+REPLY_TOPIC) when dashboard was making topic statistics #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
View file
Original file line number Diff line number Diff line change
@@ -67,7 +67,7 @@ public void run() {
inTPS += bsd.getStatsMinute().getTps();
inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed", e.getMessage());
log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed, topic [{}]", topic, e.getMessage());
}
}
}
@@ -82,7 +82,7 @@ public void run() {
outTPS += bsd.getStatsMinute().getTps();
outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed", e.getMessage());
log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed, topic [{}], group [{}]", topic, group, e.getMessage());
}
}
}
1 change: 1 addition & 0 deletions src/main/java/org/apache/rocketmq/dashboard/task/DashboardCollectTask.java
View file
Original file line number Diff line number Diff line change
@@ -254,6 +254,7 @@ private void addSystemTopic() throws Exception {
for (Map.Entry<String, Set<String>> entry : clusterTable.entrySet()) {
String clusterName = entry.getKey();
TopicValidator.addSystemTopic(clusterName);
TopicValidator.addSystemTopic(MixAll.getReplyTopic(clusterName));
Set<String> brokerNames = entry.getValue();
for (String brokerName : brokerNames) {
TopicValidator.addSystemTopic(brokerName);