Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize LmqPullRequestHoldService#checkHoldRequest logic #8341

Open
1 task done
mxsm opened this issue Jun 30, 2024 · 0 comments · May be fixed by #8342
Open
1 task done

[Enhancement] Optimize LmqPullRequestHoldService#checkHoldRequest logic #8341

mxsm opened this issue Jun 30, 2024 · 0 comments · May be fixed by #8342
Labels
type/enhancement

Comments

@mxsm
Copy link
Member

mxsm commented Jun 30, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

image

Motivation

Optimize LmqPullRequestHoldService#checkHoldRequest logic

Describe the Solution You'd Like

remove mpr.getPullRequestList() == null judgement

Describe Alternatives You've Considered

image
mpr.getPullRequestList() never eq null

Additional Context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8341]Optimize LmqPullRequestHoldService#checkHoldRequest logic mxsm/rocketmq
1 participant
@mxsm