-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6629] Rewrite the issue/PR template of RocketMQ #6645
Conversation
71b8d9b
to
fc497d5
Compare
bd67302
to
93bb08d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6645 +/- ##
==============================================
+ Coverage 0 43.08% +43.08%
- Complexity 0 8990 +8990
==============================================
Files 0 1107 +1107
Lines 0 78307 +78307
Branches 0 10208 +10208
==============================================
+ Hits 0 33742 +33742
- Misses 0 40343 +40343
- Partials 0 4222 +4222 see 1107 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add templates like 'enhancement' in addition to 'bug_report' and 'feature_request'? For example, for typo fixes or small optimizations that may not be big enough to be considered a feature request.
Nice idea! I will add a new template about it. |
791b328
to
52e983d
Compare
1f34d13
to
70a301b
Compare
@RongtongJin I have already added the template of enhancement.
By the way, I believe typos should be classified as bugs rather than enhancements; the criteria for an issue to be classified as an enhancement is very strict. Most of issues should be classified as bug or feature request. |
e2b612f
to
be63901
Compare
be63901
to
6a406a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Fixes #6629