Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8579] Update the startup script of RocketMQ on Windows #8580

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cyb1103
Copy link

@cyb1103 cyb1103 commented Aug 24, 2024

Which Issue(s) This PR Fixes

8579

Fixes #issue_id

Brief Description

There is a problem with obtaining the JDK version script in Windows, so I modified it;
I don't know much about different JDK versions (mainly divided by 17), and only made modifications to the issues I found

How Did You Test This Change?

I can run it normally on my computer

"JAVA_MAJOR_VERSION=**" is the log I added during debugging

run with java 17
image
run with java 8
image

@cyb1103 cyb1103 marked this pull request as draft August 25, 2024 03:25
@cyb1103 cyb1103 marked this pull request as ready for review August 25, 2024 03:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.23%. Comparing base (e8d87b1) to head (f02d132).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8580      +/-   ##
=============================================
- Coverage      47.27%   47.23%   -0.05%     
+ Complexity     11453    11443      -10     
=============================================
  Files           1275     1275              
  Lines          89242    89242              
  Branches       11470    11470              
=============================================
- Hits           42185    42149      -36     
- Misses         41861    41888      +27     
- Partials        5196     5205       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins changed the title [#8579]Update the startup script of RocketMQ on Windows [ISSUE #8579] Update the startup script of RocketMQ on Windows Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants