Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8621] Optimise consumer message printing #8622

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8621] Optimise consumer message printing #8622

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f79cbe4
Adding null does not update
weihubeats Jun 8, 2023
0d4e93e
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Jul 26, 2023
b621456
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Aug 17, 2023
35a7d4c
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Oct 16, 2023
199999e
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Oct 18, 2023
5fbbed2
merge
weihubeats Feb 27, 2024
f52d41e
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Mar 20, 2024
11f0867
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Apr 19, 2024
c930b08
Merge remote-tracking branch 'refs/remotes/apache_master/develop' int…
weihubeats May 22, 2024
9eb378e
rolling back
weihubeats May 22, 2024
842fec8
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Jun 11, 2024
1eba5d6
Merge remote-tracking branch 'refs/remotes/apache_master/develop' int…
weihubeats Jun 27, 2024
acb4ede
Merge remote-tracking branch 'refs/remotes/apache_master/develop' int…
weihubeats Jul 3, 2024
db1ae3f
Merge remote-tracking branch 'upstream/develop' into develop
weihubeats Jul 8, 2024
5b6637e
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Sep 2, 2024
215a82b
Merge remote-tracking branch 'weihubeats_master/develop' into weihube…
weihubeats Sep 2, 2024
5f7d36b
Optimise consumer message printing
weihubeats Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,7 @@ public void persistAll(Set<MessageQueue> mqs) {
if (mqs.contains(mq)) {
try {
this.updateConsumeOffsetToBroker(mq, offset.getOffset());
log.info("[persistAll] Group: {} ClientId: {} updateConsumeOffsetToBroker {} {}",
this.groupName,
this.mQClientFactory.getClientId(),
mq,
offset.getOffset());
printConsumerDetail(mq, offset.getOffset());
} catch (Exception e) {
log.error("updateConsumeOffsetToBroker exception, " + mq.toString(), e);
}
Expand All @@ -160,17 +156,21 @@ public void persist(MessageQueue mq) {
if (offset != null) {
try {
this.updateConsumeOffsetToBroker(mq, offset.getOffset());
log.info("[persist] Group: {} ClientId: {} updateConsumeOffsetToBroker {} {}",
this.groupName,
this.mQClientFactory.getClientId(),
mq,
offset.getOffset());
printConsumerDetail(mq, offset.getOffset());
} catch (Exception e) {
log.error("updateConsumeOffsetToBroker exception, " + mq.toString(), e);
}
}
}

private void printConsumerDetail(MessageQueue mq, long offset) {
log.info("[persist] Group: {} ClientId: {} updateConsumeOffsetToBroker {} offset: {}",
this.groupName,
this.mQClientFactory.getClientId(),
mq,
offset);
}

public void removeOffset(MessageQueue mq) {
if (mq != null) {
this.offsetTable.remove(mq);
Expand Down
Loading