-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve]Optimize the way of obtaining user information. #267
[Improve]Optimize the way of obtaining user information. #267
Conversation
@Hisoka-X PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangshenghang this makes a lot of sense, but isn't it possible to leverage |
ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor(); | ||
executor.setCorePoolSize(10); | ||
executor.setMaxPoolSize(20); | ||
executor.setQueueCapacity(100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make these parameters configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make these parameters configurable.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you have added async-config, but it is not being used in this code. Could you please verify this? Additionally, ensure that if the async-config entry is missing from the configuration, the default values are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangshenghang can you please handle this
Nice improvement, Thanks @zhangshenghang |
@shashwatsai Yes, currently the project does not use |
172adbf
to
0ed459d
Compare
6d790f2
to
33e31ad
Compare
@arshadmohammad @Hisoka-X PTAL |
|
OK. I forgot to submit it. It has been revised. |
@arshadmohammad @Hisoka-X PTAL |
Many integration tests are failing @zhangshenghang can you please run the integration tests and handle the failure. |
Apologies for the confusion. After upgrading my existing Seatunnel database by executing the script below, the test cases have now passed. ALTER TABLE |
Purpose of this pull request
In the Spring project, the user ID should not be passed in through the front end, but the general Servlet should be used to obtain user information.
Check list
New License Guide