[Feature] Add Support for encrypting config fields #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashwatsai
force-pushed
the
feature/intermediate-job-config-encryption
branch
from
a30d3d1 to
1d7c588
Compare
| @@ -52,7 +52,13 @@ jwt: | |||
| secretKey: | |||
| algorithm: HS256 | |||
|
|
|||
|
|
|||
| seatunnel-web: | |||
There was a problem hiding this comment.
In an earlier PR, we placed the Seatunnel-web specific configuration under the spring config section.
You have now put seatunnel-web specific configuration under the seatunnel-web config section.
This seems to be a better approach. Later, we can also move the configurations from the earlier PR under the seatunnel-web config section.
| @Autowired private EncryptionConfig encryptionConfig; | ||
|
|
||
| public void encryptData(Map<String, String> datasourceConfig) { | ||
| for (String key : encryptionConfig.getKeysToEncrypt()) { |
There was a problem hiding this comment.
When encryption type is default it does not do any encoding/decoding. can we simply return from where when encoding is default.
| seatunnel-web: | ||
| datasource: | ||
| encryption: | ||
| type: default |
There was a problem hiding this comment.
can we use none instead of default
| @@ -324,6 +331,10 @@ public String generateJobConfig( | |||
| if (sinkMap.size() > 0) { | |||
| sinks = getConnectorConfig(sinkMap); | |||
| } | |||
| envConfig = | |||
There was a problem hiding this comment.
add this config only when encryption is enabled.
While writing intermediate config to submit job via seatunnel client,
we are required to encrypt certain fields like password, auth, username
By Default no encryption would be done, to enable the encryption
provide the following properties
```
seatunnel-web:
datasource:
encryption:
type: your_encryption
keys-to-encrypt:
- password
- auth
```
ref: https://seatunnel.apache.org/docs/2.3.9/connector-v2/Config-Encryption-Decryption/
Co-authored-by: BilwaST <[email protected]>
Co-authored-by: Shashwat Tiwari <[email protected]>
shashwatsai
force-pushed
the
feature/intermediate-job-config-encryption
branch
from
1d7c588 to
4ad6dae
Compare
arshadmohammad
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
While writing intermediate config to submit job via seatunnel client, we are required to encrypt certain fields like password, auth, username
By Default no encryption would be done, to enable the encryption provide the following properties
ref: https://seatunnel.apache.org/docs/2.3.9/connector-v2/Config-Encryption-Decryption/
Check list
New License Guide