[Improve][Core] Add check of sink and source config to avoid null poi…

…nter exception. (#4734)
apache · May 15, 2023 · 8f66ce9 · 8f66ce9
1 parent 28f2314
commit 8f66ce9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/...ava/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalogFactory.java b/...ava/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MySqlCatalogFactory.java
@@ -17,6 +17,8 @@
 
 package org.apache.seatunnel.connectors.seatunnel.jdbc.catalog.mysql;
 
+import org.apache.seatunnel.shade.com.google.common.base.Preconditions;
+
 import org.apache.seatunnel.api.configuration.ReadonlyConfig;
 import org.apache.seatunnel.api.configuration.util.OptionRule;
 import org.apache.seatunnel.api.configuration.util.OptionValidationException;
@@ -26,6 +28,8 @@
 import org.apache.seatunnel.common.utils.JdbcUrlUtil;
 import org.apache.seatunnel.connectors.seatunnel.jdbc.catalog.JdbcCatalogOptions;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.auto.service.AutoService;
 
 import java.util.Optional;
@@ -41,6 +45,9 @@ public String factoryIdentifier() {
     @Override
     public Catalog createCatalog(String catalogName, ReadonlyConfig options) {
         String urlWithDatabase = options.get(JdbcCatalogOptions.BASE_URL);
+        Preconditions.checkArgument(
+                StringUtils.isNoneBlank(urlWithDatabase),
+                "Miss config <base-url>! Please check your config.");
         JdbcUrlUtil.UrlInfo urlInfo = JdbcUrlUtil.getUrlInfo(urlWithDatabase);
         Optional<String> defaultDatabase = urlInfo.getDefaultDatabase();
         if (!defaultDatabase.isPresent()) {

diff --git a/...-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java b/...-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java
@@ -18,6 +18,7 @@
 package org.apache.seatunnel.core.starter.utils;
 
 import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.node.ObjectNode;
+import org.apache.seatunnel.shade.com.google.common.base.Preconditions;
 import org.apache.seatunnel.shade.com.typesafe.config.Config;
 import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory;
 import org.apache.seatunnel.shade.com.typesafe.config.ConfigRenderOptions;
@@ -142,6 +143,10 @@ private static Config processConfig(String identifier, Config config, boolean is
                 (ArrayList<Map<String, Object>>) configMap.get(Constants.SOURCE);
         List<Map<String, Object>> sinks =
                 (ArrayList<Map<String, Object>>) configMap.get(Constants.SINK);
+        Preconditions.checkArgument(
+                !sources.isEmpty(), "Miss <Source> config! Please check the config file.");
+        Preconditions.checkArgument(
+                !sinks.isEmpty(), "Miss <Sink> config! Please check the config file.");
         sources.forEach(
                 source -> {
                     for (String sensitiveOption : sensitiveOptions) {